Fix file_alloc_aligned() and add the allocFreeAligned test to poolFixtures.hpp #1247
+71
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_allocFreeAligned_test
branch
2 times, most recently
from
a6c4210 to
3b84556
Compare
ldorau
force-pushed
the
Add_allocFreeAligned_test
branch
from
3b84556 to
69ab584
Compare
PatKamin
approved these changes
Apr 10, 2025
bratpiorka
reviewed
Apr 10, 2025
`new_offset_mmap` can be greater than `file_provider->size_mmap`, so `file_provider->size_mmap - new_offset_mmap` would be an underflow in this case. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_allocFreeAligned_test
branch
from
69ab584 to
b623170
Compare
bratpiorka
approved these changes
Apr 10, 2025
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_allocFreeAligned_test
branch
from
b623170 to
9990b34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix file_alloc_aligned() and add the allocFreeAligned test to poolFixtures.hpp.
Checklist